[SPARK-49756][SQL] Postgres dialect supports pushdown datetime functions. #48210
+108
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
changed the title
Contributor
Author
|
ping @cloud-fan Please help me review this PR. |
cloud-fan
reviewed
Sep 30, 2024
| } | ||
| } | ||
|
|
||
| override def compileExpression(expr: Expression): Option[String] = { |
Contributor
There was a problem hiding this comment.
this is an interesting change. Shall we do this by default? It's better to push down nothing than failing.
cloud-fan
reviewed
Sep 30, 2024
| } | ||
| } | ||
|
|
||
| override def testDatetime(tbl: String): Unit = { |
Contributor
There was a problem hiding this comment.
just for my curiosity, what does super.testDatatime do? an empty function?
Contributor
Author
There was a problem hiding this comment.
Yes. Just is an empty function.
cloud-fan
approved these changes
Oct 10, 2024
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@cloud-fan Thank you! |
cloud-fan
added a commit
that referenced
this pull request
Feb 28, 2025
…ushing down EXTRACT ### What changes were proposed in this pull request? This is a followup of #48210 to fix correctness issues caused by pgsql filter pushdown. These datetime fields were picked wrongly before, see https://neon.tech/postgresql/postgresql-date-functions/postgresql-extract ### Why are the changes needed? bug fix ### Does this PR introduce _any_ user-facing change? Yes, query result is corrected, but this bug is not released yet. ### How was this patch tested? updated test ### Was this patch authored or co-authored using generative AI tooling? no Closes #50101 from cloud-fan/pgsql. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
added a commit
that referenced
this pull request
Feb 28, 2025
…ushing down EXTRACT ### What changes were proposed in this pull request? This is a followup of #48210 to fix correctness issues caused by pgsql filter pushdown. These datetime fields were picked wrongly before, see https://neon.tech/postgresql/postgresql-date-functions/postgresql-extract ### Why are the changes needed? bug fix ### Does this PR introduce _any_ user-facing change? Yes, query result is corrected, but this bug is not released yet. ### How was this patch tested? updated test ### Was this patch authored or co-authored using generative AI tooling? no Closes #50101 from cloud-fan/pgsql. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 208a7ee) Signed-off-by: Wenchen Fan <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…ushing down EXTRACT ### What changes were proposed in this pull request? This is a followup of apache#48210 to fix correctness issues caused by pgsql filter pushdown. These datetime fields were picked wrongly before, see https://neon.tech/postgresql/postgresql-date-functions/postgresql-extract ### Why are the changes needed? bug fix ### Does this PR introduce _any_ user-facing change? Yes, query result is corrected, but this bug is not released yet. ### How was this patch tested? updated test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50101 from cloud-fan/pgsql. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit e65434e) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose to make Postgres dialect supports pushdown datetime functions.
Why are the changes needed?
Currently, DS V2 pushdown framework pushed the datetime functions with in a common way. But Postgres doesn't support some datetime functions.
Does this PR introduce any user-facing change?
'No'.
This is a new feature for Postgres dialect.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.